Add user in permissions gui doesn't do anything

[cholmes]

If I'm using the permissions gui and hit 'add user' nothing happens. Not sure what the expected behavior is, but I assume something that adds users. This doesn't work on maps or data layers (tried both with admin user, and map with a non-admin user)

[dwinslow]

The 'add user' button adds the user that you have selected in the drop-down box. You can type a couple of letters in and then it will autocomplete. If you haven't entered a user's name the button doesn't do anything.

This works for me on demo.

[sbenthall]

Ok, there are some UI design issues here. My experience with the widget is also, 'this is broken.'

One problem is that the box for inputting the user name has a dropdown button that doesn't do anything.

[dwinslow]

Replying to sbenthall:

Ok, there are some UI design issues here. My experience with the widget is also, 'this is broken.'

There were some problems with the permissions dialog on the layer detail page; they should be fixed now. Are you still seeing breakage?

One problem is that the box for inputting the user name has a dropdown button that doesn't do anything.

The dropdown doesn't populate until you've typed a couple of characters so that you can type those characters without having to wait for a request to the server. I believe we can set a message to show up when the dropdown is unpopulated.

Another "doesn't do anything" behavior is that you cannot add yourself to the permissions list of an object you own (permissions are implicit in ownership). I think a dialog or temporary annotation of the "add user" widget could be added to hint that you attempted a disallowed option here.

[rpenate]

Replying to dwinslow who is replying to sbenthall:

One problem is that the box for inputting the user name has a dropdown button that doesn't do anything.

The dropdown doesn't populate until you've typed a couple of characters so that you can type those characters without having to wait for a request to the server. I believe we can set a message to show up when the dropdown is unpopulated.

+1 to a "Type a username or email address" message in the dropdown. See:  http://ui-patterns.com/patterns/InputPrompt

Another "doesn't do anything" behavior is that you cannot add yourself to the permissions list of an object you own (permissions are implicit in ownership). I think a dialog or temporary annotation of the "add user" widget could be added to hint that you attempted a disallowed option here.

Is there any way to have the owner show up in the permission list?

[sbenthall]

For the instructional text:  http://bit.ly/9lP4lh

[dwinslow]

Replying to rpenate:

Another "doesn't do anything" behavior is that you cannot add yourself to the permissions list of an object you own (permissions are implicit in ownership). I think a dialog or temporary annotation of the "add user" widget could be added to hint that you attempted a disallowed option here.

Is there any way to have the owner show up in the permission list?

Yes. Originally the owner did show up in the permission list, but this allowed a user to make himself no-longer an administrator of the layer. Should we just add the user to the list again and disable all relevant controls?

[sbenthall]

I think that the remaining work on this ticket is enough of an edge-case to make it a non milestone blocker

[cholmes]

The 'type username' greatly improves this - I'm now quite sure it worked before but when I did anything nothing seemed to happen.

One improvement that could be good is to have the drop down work even when nothing is filled out, and it just lists the first 10 users. Just so people know that there are users. It also appears to not try to do auto complete until more at least two characters are typed. I think we might consider doing it after one, as when I do it now I don't remember people's usernames, so want to type one character, pause, and see what populates. I concede this is an edge case, am even fine if it moves to post-1.0. I think groups are going to be essential, trying to remember usernames and adding them is just a pain.

[dwinslow]

This works now.